feat: Prop defs node spike #29476
Open
feat: Prop defs node spike #29476
+1,481
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 silly question I should have asked this morning: didn't we used to process property defs in a NodeJS service, prior to the existence of |
eli-r-ph
force-pushed
the
feat/node-prop-defs
branch
from
45f677b to
312e150
Compare
… feat/node-prop-defs # Conflicts: # plugin-server/src/property-defs/property-defs-consumer.test.ts # plugin-server/src/property-defs/property-defs-consumer.ts # plugin-server/src/types.ts
…xtraction; filter inline during extraction
…fetches; batch all event and prop writes
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces property definitions functionality to the PostHog plugin server, moving the implementation from Rust to Node.js for performance evaluation.
- Added new
PropertyDefsConsumerin/plugin-server/src/property-defs/property-defs-consumer.tsto process and store property definitions from Kafka events - Implemented
PropertyDefsDBin/plugin-server/src/property-defs/services/property-defs-db.tsfor handling database operations with proper upsert logic - Added configuration options in
config.tsfor controlling property definitions consumer behavior, including team-specific enabling and write disabling - Added comprehensive type inference utilities in
property-defs-utils.tsfor determining property types from values - Modified
GroupTypeManagerandTeamManagerto support batch operations and improved caching for property definitions
Note: There are some TODOs around project_id implementation and timestamp handling that need to be addressed.
13 file(s) reviewed, 14 comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Needs #29772
We want to experiment with prop defs in Node to get a real life feel for perf and to determine if this is our way forward (it's a spike to gather data fast rather than to become a big discussion - we want to get data to inform future decisions)
This is good enough now to get something running, doing the parsing so we can check out the cpu profile etc.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?